StackExchange / dnscontrol

Infrastructure as code for DNS!
https://dnscontrol.org/
MIT License
3.08k stars 390 forks source link

Oracle - Provider leaves trailing dot on nameserver #3089

Closed fabienmazieres closed 1 week ago

fabienmazieres commented 3 weeks ago

Describe the bug

When running the Oracle provider, I get the following error message: **** Domain: example.co.uk ERROR: ERROR: error while getting Nameservers for zone="example.co.uk" with provider="oracle": provider code leaves trailing dot on nameserver

It appears that Oracle changed the way they handle trailing dot as I can see that this was previously changed to the stripTD function: #1341

To Reproduce

Create a test domain with Oracle as provider, such as:

var REG_NONE = NewRegistrar("none");
var DSP_ORACLE = NewDnsProvider("oracle");

D("example.co.uk", REG_NONE, DnsProvider(DSP_ORACLE),
    // Top-level domain configuration
    NAMESERVER_TTL("172800"), // 2 days

    // Records
    A("test", "1.2.3.4"),
    END);

run dnscontrol preview

Error message displayed:

******************** Domain: example.co.uk
ERROR: ERROR: error while getting Nameservers for zone="example.co.uk" with provider="oracle": provider code leaves trailing dot on nameserver
Done. 0 corrections

Expected behavior

No error message seen when running provider

DNS Provider

Oracle

Additional context

Be aware of PR #1341 that changed the behavior some time ago.

fabienmazieres commented 1 week ago

fixed in release v4.13.0