StackExchange / dnscontrol

Infrastructure as code for DNS!
https://dnscontrol.org/
MIT License
3.01k stars 378 forks source link

More providers should implement "get-zones" #628

Closed tlimoncelli closed 4 years ago

tlimoncelli commented 4 years ago

Commit 87ad01d194ddc05950e79382c838d348e11d3db2 added a new subcommand called "get-zones" which replaces the (mostly broken) convertzone command. It is a stand-alone command that allows users to download zone records from a provider. It is useful for bootstrapping your dnsconfig.js configuration.

This subcommand works for any provider that implements a new function called GetZoneRecords. I've added such a function to all providers that simply outputs "not implemented". I'm asking that all providers replace this function with one that actually does the required task. Initially I've implemented it for BIND, GANDI_V5, and @captncraig wrote one for CLOUDFLAREAPI.

The functional is fairly easy to implement since the code exists in GetZoneCorrections(). One simply (?) extracts out that code into a separate function.

We'll consider this bug complete when both of these statements are true:

This feature blocks the 3.0 release.

aeden commented 4 years ago

@tlimoncelli for DNSimple I'm going to ask @onlyhavecans to implement it.

KaiSchwarz-cnic commented 4 years ago

@tlimoncelli for HEXONET I'll dive into the review in mid of march. As I am very busy, I can't handle it earlier.

tlimoncelli commented 4 years ago

@tlimoncelli for HEXONET I'll dive into the review in mid of march. As I am very busy, I can't handle it earlier.

Sounds good!

pgaskin commented 4 years ago

I'll probably get to this sometime before March, but not in the next week.

masterzen commented 4 years ago

@tlimoncelli I've finally implemented GetZoneRecords for ovh in the #666 PR (sorry for the delay). Feel free to review and merge it if you think it is ready.

Thanks !

tlimoncelli commented 4 years ago

With OVH support get-zones, we are at 50% and can consider this ready for 3.0! Thanks to @masterzen for putting us over the finish line!

pragmaton commented 4 years ago

ClouDNS - done in https://github.com/StackExchange/dnscontrol/pull/681

pragmaton commented 4 years ago

INTERNETBS - only Registrar for now and I don't have any plans to implement any DNS Provider functions.

tlimoncelli commented 4 years ago

Enough providers have implemented this that I'll consider it "done". Providers are encouraged to continue with updates.