Update go.mod - Githubissues

StackExchange / wmi

WMI for Go

http://godoc.org/github.com/StackExchange/wmi

MIT License

433 stars 173 forks source link

Update go.mod #58

Closed czxcc closed 3 years ago

czxcc commented 3 years ago

module declares

lespea commented 3 years ago

Without this pr you can't fetch this package at all with go mod. Please merge asap.

lespea commented 3 years ago

Also since you've adding go.mod you should probably do a new tagged release.

tlimoncelli commented 3 years ago

I've added the tag. Please verify (my git knowledge isn't the greatest :-( )

lespea commented 3 years ago

I believe you need to make the tag v1.2.0

tlimoncelli commented 3 years ago

Done.

lespea commented 3 years ago

Did you accidentally tag the wrong commit? v1.2.0 is pointing to fe8f175 but 1.2.0 is pointing to 37ec4cb. fe8f175 was before any of the go.mod stuff was added. I'm also not 100% but you might need to remove the 1.2.0 tag? Maybe not but might be confusing having 2 tags for the same version.

tlimoncelli commented 3 years ago

Drat. I didn't do a "git pull".

I removed and re-added the v1.2.0 tag. PTAL

lespea commented 3 years ago

Perfect!

> go mod verify && go mod tidy
all modules verified
go: downloading github.com/StackExchange/wmi v1.2.0