search

StackGuardian / tirith

StackGuardian Policy Framework
Apache License 2.0
117 stars 37 forks source link

Simplify type checking in sort_collections() Closes https://github.com/StackGuardian/tirith/issues/185 #186

Closed gabrilito1 closed 2 weeks ago

gabrilito1 commented 2 weeks ago

Update the sort_collections function in the utils.py to use a single isinstance check for primitive types.

gabrilito1 commented 2 weeks ago

Done, give me a feedback asap

refeed commented 2 weeks ago

BTW @gabrilito1 , I forgot to mention that what I meant by the commit message is the git commit message. Ideally, we could squash the commits into one and then use git commit --amend to change the commit message and then do force push again. But for now, it's fine, we'll do it on my side, but if you want to change the commit message, feel free to do so

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud