Closed Dev-iL closed 6 years ago
Things to do before the PR is merged (comments by @altmany):
RE: 8 on your list, since we're using this as an Abstract class I'm not sure we'll be able to do this. I'd prefer not having to instantiate the class just to have a settable timeiout, so it may have to be done using a global
or an external settings file that can be parsed.
re 8, you could have a setTimeout(hFig,value) function that would _setappdata(hFig,'QUERYTIMEOUT',value) and then whenever you want to check for the timeout you could do something like:
timeout = getappdata(hFig,'QUERY_TIMEOUT');
if isempty(timeout), timeout = mlapptools.QUERY_TIMEOUT; end
while true && (toc < timeout)
...
@sco1 @altmany I have added some more commits that address most of the suggestions above.
uifigure
and a "uielement") is confusing. Instead, we can rename the current method to getWidgetListing
and implement Yair's suggestion under the current name (getWidgetInfo
).Thoughts / comments?
Implemented 5 as explained in my previous comment. Tested all code examples manually. I think it's ready to merge now. Will wait for comments until the end of the day before merging.
Haven't had a chance to play with the newest functionality but it still looks OK to me. I'm assuming you guys have looked at it pretty thoroughly so I'm confident that it works as desired.
Until MATLAB renders external README documents I'd prefer to keep at least a framework of the inline documentation in place so folks have at least something useful show up with doc
/help
. I'd still defer to the README for more in-depth information.
Also, once this PR is merged I'll go back through and tag releases as requested...wherever it was requested.
Waiting for your merge to post the followup article on UndocumentedMatlab.com
Thanks for the great work @sco1 & @Dev-iL - very high-quality code, and nifty research indeed into the Dojo underworld :-)
I'm 100% certain that this will get MathWorks' attention, and for a very good reason - they should have included this functionality in their code ages ago.
@altmany Fingers crossed! More than a few head scratchers with the new UI engine, as much as I love it.
I dream of a day when we can get documented methods for things like centering text without having to muck through the underlying graphics engine. Though there will always be a soft spot in my heart for the many hours spent with findjobj
:relaxed:
Added some methods for manipulating uitables, and an accompanying demo app. Also included some minor refactoring of method names to follow Java conventions (internal functions, so no change to API).
NOTE: As of the creation of the PR, the markdown documentation wasn’t updated, so please see
\Demo\TableDemo.m
for a demonstration of the new functionality.