StackStorm-Exchange / exchange-incubator

Submit your StackStorm integration and automation packs here.
12 stars 61 forks source link

New SQL pack #137

Closed nmaludy closed 5 years ago

nmaludy commented 5 years ago

This is a generic SQL pack that can be used to connect to multiple SQL backend servers instead of requiring unique packs per SQL type (mysql, postgres, mssql, etc).

nmaludy commented 5 years ago

@bishopbm1 looks like this is failing because gcc isn't installed in the testing container.

@LindsayHill are we OK to modify the CircleCI config to add in unique system-level dependencies for pack testing?

LindsayHill commented 5 years ago

It's not gcc missing - it's something else:

    src/pyodbc.h:56:17: fatal error: sql.h: No such file or directory
     #include <sql.h>

Which system package is that in?

nmaludy commented 5 years ago

@bishopbm1 looks like the readme needs updating, i had to install the following just to get the pack on my system:

gcc
gcc-c++
mysql-devel
unixODBC-devel
nmaludy commented 5 years ago

Looks like if we use pymysql instead of mysqlclient then we don't need the system level mysql-devel dependency: https://docs.sqlalchemy.org/en/latest/dialects/mysql.html#module-sqlalchemy.dialects.mysql.pymysql

nmaludy commented 5 years ago

Same thing with replacing pyodbc with pymssql this can avoid the system-level dependency of MSSQL https://docs.sqlalchemy.org/en/latest/dialects/mssql.html#module-sqlalchemy.dialects.mssql.pymssql

nmaludy commented 5 years ago

@LindsayHill We've updated the pack to use Python library implementations instead of requiring system-level packages be installed. Think this is good to go now.

LindsayHill commented 5 years ago

https://github.com/StackStorm-Exchange/stackstorm-sql created - you want to do PR against that?