StackStorm-Exchange / exchange-incubator

Submit your StackStorm integration and automation packs here.
12 stars 61 forks source link

Includes new stackstorm-aoscx pack #154

Closed tchiapuziowong closed 3 years ago

tchiapuziowong commented 3 years ago
tchiapuziowong commented 3 years ago

Pyaoscx updated : https://pypi.org/project/pyaoscx/ https://github.com/aruba/pyaoscx/pull/1

tchiapuziowong commented 3 years ago

Hello! Is there any way to re-launch this test?

punkrokk commented 3 years ago

You can also do a commit. Restarted

JP Bourget / @punkrokk

On Sep 28, 2020, at 7:49 PM, tchiapuziowong notifications@github.com wrote:

 Hello! Is there any way to re-launch this test?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

tchiapuziowong commented 3 years ago

Hello! Is there any update to this?

amanda11 commented 3 years ago

I took a look at the failure, and re-ran build. But I wonder if the problem is that the library is python 3 only. As the build failure shows:

`Using /home/circleci/virtualenv/lib/python2.7/site-packages
Finished processing dependencies for st2common==3.3.dev0
Installing pack requirements from /home/circleci/repo/requirements.txt
...
Collecting pyaoscx>=0.2.1 (from -r /home/circleci/repo/requirements.txt (line 3))
  Could not find a version that satisfies the requirement pyaoscx>=0.2.1 (from -r /home/circleci/repo/requirements.txt (line 3)) (from versions: 0.1.1, 0.1.2, 0.2.0)

But python_versions is listed as 3 only, so I'm not sure why its trying to run in a python 2.7 enviornment. So it looks like it is trying to run in python 2 environment.

tchiapuziowong commented 3 years ago

Hi @amanda11 ! Thank you so much for looking into this! It appears this review cannot pass CircleCi unless https://github.com/StackStorm-Exchange/exchange-incubator/pull/155 is merged. I'll ask for an update on that review as well. Thank you again for your support!

blag commented 3 years ago

You also need to add a LICENSE file with the Apache license text (packs listed on StackStorm-Exchange MUST be licensed under the Apache 2 license).

See the LICENSE file in the stackstorm-vault pack: https://github.com/StackStorm-Exchange/stackstorm-vault/blob/master/LICENSE

blag commented 3 years ago

The pylint linter is having trouble ensuring that aoscx_websocket is an importable package:

************* Module port_sensor
E:  2, 0: Unable to import 'aoscx_websocket' (import-error)

Import line is here:

from aoscx_websocket import Client  # NOQA

Is that package open source and available on PyPI?

tchiapuziowong commented 3 years ago

Hello - is there any update to this? @blag

nmaludy commented 3 years ago

Closing this PR since https://github.com/StackStorm-Exchange/stackstorm-aoscx was created with your code. Enjoy!