search

StackStorm-Exchange / exchange-incubator

Submit your StackStorm integration and automation packs here.
12 stars 61 forks source link

Use circleci/python:3.6 image in CircleCI tests #155

Closed blag closed 3 years ago

blag commented 3 years ago

The CircleCI tests for StackStorm-Exchange/exchange-incubator#154 failed because it relied on the Python 3-only package pyaoscx but the tests were running in a circleci/python:2.7 container.

This PR updates the CI container to run in the most recent circleci/python:3.6 image, since all future packs should support Python 3. And frankly, at this point I think all new packs should only support Python 3, so I didn't even bother duplicating the workflow for Python 3.6, I just updated the existing workflow.

tchiapuziowong commented 3 years ago

Hello! Is it possible to re-run a CircleCI test on a pull review using this code?

punkrokk commented 3 years ago

Just Relaunched.

JP Bourget / @punkrokk

On Sep 28, 2020, at 6:44 PM, tchiapuziowong notifications@github.com wrote:

 Hello! Is it possible to re-run a CircleCI test on a pull review using this code?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

tchiapuziowong commented 3 years ago

Hello! My pull request #154 is failing due to CircleCI running in Python2.7 venv instead of Python3 - this commit should resolve that error correct? There's nothing to be done in the pack side?

tchiapuziowong commented 3 years ago

Hello! Is there any update to the status of this review? My pack seems to be dependent on this review in order to be merged.

tchiapuziowong commented 3 years ago

Hello - is there any update to this request? @blag

blag commented 3 years ago

@armab The tests in .circleci in this repository aren't for this repository, they're the template for packs forked off of this repository (this should definitely be documented). So these tests will never pass for this repo. See #149.