search

StackStorm-Exchange / exchange-incubator

Submit your StackStorm integration and automation packs here.
12 stars 61 forks source link

ST2 Pack for GreyNoise API #164

Closed bradchiappetta closed 3 years ago

bradchiappetta commented 3 years ago

This is a pack with actions to interact with the GreyNoise API. More information at greynoise.io/tech

Would love some feedback on this as this is my first pack submission, and I'm sure there are plenty of places for improvement.

bradchiappetta commented 3 years ago

Still need to fix the publishing syntax, but otherwise looks good.

@blag : so, when I tried your suggested modification, that is when I got the stacktrace error (with the changes to publishing). If I run this as it is currently in the PR, it all works as expected with no errors. Can you provide some additional guidance?

blag commented 3 years ago

I think this looks good. The Orquesta context variable publishing still looks a little weird to me, but if it's working for you then that must be a supported syntax.

Thank you for the contribution!

I'll be releasing v3.4 tomorrow, so I won't have time to put this on Exchange until Wednesday at the earliest. Feel free to ping me if I forget.

bradchiappetta commented 3 years ago

@blag : Congrats on getting ST2 v3.4 shipped! Just wanted to remind you about this, as you suggested. Thanks!

blag commented 3 years ago

I have a few 3.4.1 post-release items to take care of, but I should get to this later today/tonight, or tomorrow. :+1:

blag commented 3 years ago

Sorry it took me so long. I have created the GreyNoise pack here: https://github.com/StackStorm-Exchange/stackstorm-greynoise

I still need to setup the Slack integration, but I'm going to need some help with that and I don't consider it a blocker.

I have invited you as a collaborator with write access, which should help you maintain the code. We try to create pull requests for every change we make to packs, and we follow SemVer to let downstream users (which may be other pack authors) know when certain versions have breaking changes.

While you are still starting out, please create pull requests and request a review from @nmaludy, me, or @StackStorm-Exchange/stackstorm-exchange, and wait to merge until somebody has signed off on it. But as you get more comfortable with maintaining the pack, you don't need to wait for reviews all of the time (although please do still put your changes into a PR). I'll promote you to have Maintainer access to this repository once you've got a few pack versions published.

If you need anything else, there are some great people in the #exchange channel in our Slack community, feel free to stop by to ask questions, say hi, or just hang out.

Closing.