search

StackStorm-Exchange / exchange-incubator

Submit your StackStorm integration and automation packs here.
12 stars 61 forks source link

Contribute new pack for Cisco ISE #166

Closed namachieli closed 2 years ago

namachieli commented 3 years ago

A Pack that uses requests and primarily yaml actions to interact with the Cisco ISE API.

namachieli commented 3 years ago

Pending review and feedback. Otherwise pack is ready to merge.

namachieli commented 3 years ago

@blag @nmaludy Please review and provide feedback. Thank you!

ip-sf commented 3 years ago

Do you have a script to generate all off the action metadata files from some kind of openapi spec? Or did you make all of them by hand?

All by hand. Unfortunately the ISE API itself a bit inconsistent, and the documentation is even more so. It is rife with typos, incomplete data, missing structure, and some bit that are just plain wrong.

Also, could you run black on your python code?

I am not familiar, but I will investigate. Thank you for the heads up!

I think using a common python entry point for all of these actions is a pretty sweet idea. I like how you've minimized things.

Thank you! 😄

These are my gut reactions - I hope the feedback is helpful.

Feedback is always appreciated! I will review and reply to each, thank you for taking the time to do so.

namachieli commented 3 years ago

@blag @nmaludy @cognifloyd

Anything else needed before this is approved?

cognifloyd commented 3 years ago

@namachieli A lot of the maintainers have been very busy with work and other things, so merging stuff can take a really long time. For example, given blag's work commitments he just announced that he's stepping down as a maintainer. And nmaludy switched jobs not too long ago, so he's been swamped with lots to do. Sorry about the delays getting this in!

I can't officially approve this or create the git repo it needs to be in. Hopefully, someone will have time to do it sooner rather than later.

Thank you for your patience, and, again, sorry this is taking awhile.

namachieli commented 3 years ago

Understood, thank you for replying. It's a tough situation for all.

blag commented 3 years ago

Just a note: the end goal of PRs here isn't actually to get merged.

Somebody with enough access needs to either run this script: https://github.com/StackStorm-Exchange/ci/blob/master/utils/exchange-bootstrap.sh

Or follow those steps to get this bootstrapped into StackStorm Exchange.

Since I'm leaving, I think somebody else should take up the mantle here. I'm happy to lend a hand if they run into trouble, but I'd like to pass this knowledge on to somebody else to maintain that ability in the TSC.

arm4b commented 2 years ago

Closing as https://github.com/stackStorm-exchange/stackstorm-cisco_ise pack is available in the StackStorm Index: https://exchange.stackstorm.org/#cisco_ise