search

StackStorm-Exchange / exchange-incubator

Submit your StackStorm integration and automation packs here.
12 stars 61 forks source link

Add reviewboard pack #167

Closed murthysrd closed 2 years ago

cognifloyd commented 3 years ago

Why is the pack named rbtools? I think reviewboard would be a better name.

murthysrd commented 3 years ago

It was named rbtools as the python package for tools they (reviewboard) provided was named RBTools

cognifloyd commented 3 years ago

RBtools makes sense on PyPI because it is not reviewboard itself, which is written in python. There is no confusion for content packs, however, because comment packs are not distributed through PyPI. I have a couple of packs to create this week. Can I ask this one as reviewboard instead of rbtools? rbtools sounds like Ruby tools, which is confusing for me and maybe other people who don't use reviewboard.

murthysrd commented 2 years ago

I made the change to pack name and configuration files

cognifloyd commented 2 years ago

I'm working on getting set up so I can bootstrap packs. I'll let you know when I'm done.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

cognifloyd commented 2 years ago

Closed and reopened to retrigger CI

cognifloyd commented 2 years ago

!bootstrap pack

cognifloyd commented 2 years ago

@murthysrd I'm sorry for the comment spam. This is the first PR that I'm pushing through a new pack bootstrap workflow, and I keep finding edge cases that I didn't account for when testing it before.

cognifloyd commented 2 years ago

!bootstrap pack

github-actions[bot] commented 2 years ago

:rocket: Hold onto your hats! Now bootstrapping a new pack repo...

Bootstrapping will: (1) extract details about the new pack; (2) create the pack repo and repo metadata; (3) copy this PR into the transfer branch in the new repo; (4) use transfer branch for the pack's first PR.

Details: https://github.com/StackStorm-Exchange/exchange-incubator/runs/2367869733

cognifloyd commented 2 years ago

OK. So, the automated workflow didn't quite work because this was in an intermediate state as I did it partially with the old setup, and partially with the new. I just finished up and merged https://github.com/StackStorm-Exchange/stackstorm-reviewboard/pull/1.

Here's what's left:

  1. a TSC Senior Maintainer needs to set up group and user access;
  2. some repo settings didn't get configured correctly. I'll revisit these when we audit / fix it across the whole exchange in the future.
    • ~repo description and homepage~ Looks like Maintainers can just edit that, so I did it manually.
    • protected branches
cognifloyd commented 2 years ago

BTW: this pack is now on the index https://exchange.stackstorm.org/#reviewboard

arm4b commented 2 years ago

Thanks, @cognifloyd.

I've set the branch protection and invited @murthysrd to the https://github.com/StackStorm-Exchange/stackstorm-reviewboard/ pack.

Looks like this PR could be closed as the new pack is now :green_circle: ?

cognifloyd commented 2 years ago

Thanks @armab.

And thanks @murthysrd for the new pack. I'm sorry it took eons to get the pack set up. If you submit any more packs, it should be much quicker next time.