search

StackStorm-Exchange / exchange-incubator

Submit your StackStorm integration and automation packs here.
12 stars 61 forks source link

LogicMonitor Pack #169

Closed lm-ydubler closed 2 years ago

lm-ydubler commented 2 years ago

This is the official LogicMonitor Pack for StackStorm.

This Pack is to be used in conjunction with LogicMonitor's StackStorm Integration.

We might push some updates here and there but this version is functional and can be put onto StackStorm Exchange after you evaluate it to be proper.

If you have any questions please reach out to me, Yuri Dubler -- a software engineer on LogicMonitor's Integration team, at my e-mail address yuri.dubler@logicmonitor.com.

I am disallowing maintainer to edit this pack for security reasons. Please reach out to me if you guys want to change anything about this pack.

Thanks and best.

nzlosh commented 2 years ago

Hello,

Thank you for submitting your pack to the StackStorm Exchange. To provide a consistent code base across the packs, please apply the following recommendations to the submission:

Are you able to elaborate on what you mean by:

I am disallowing maintainer to edit this pack for security reasons. Please reach out to me if you guys want to change anything about this pack.

To be clear, by submitting the pack repository to the StackStorm Exchange, the StackStorm project maintainers will become the custodians of the code and will perform maintenance and apply patches.

You will be listed as a code owner, provide code reviews and have direct input on pull requests.

As a side note, we are working on moving the CI for the Exchange from CircleCI to Github, there will be delays before the pack will appear in the Exchange Index.

lm-ydubler commented 2 years ago

Hi, Thank you Carlos. I just ran black on the pack and it modified the 3 files shown here:

black-line-length-100

Those 3 files have been updated in this PR.

Thank you for mentioning those things about code ownership, etc, I will be discussing those things with my project manager to ensure everything is setup correctly. I will also follow up regarding my "I am disallowing maintainer to edit this pack for security reasons..." comment.

All that said, thanks again for all of your help and attention. Hope you're having a great day.

lm-ydubler commented 2 years ago

Hi Carlos, Thank you so much for the update. I'll get back at you regarding the comment "I am disallowing maintainer to edit this pack for security reasons. Please reach out to me if you guys want to change anything about this pack." which was related to security reasons BUT it's likely you've thought of this in your workflow.

Will follow up further soon, thank you again.

On Thu, Oct 28, 2021 at 1:10 PM Carlos @.***> wrote:

Hello,

Thank you for submitting your pack to the StackStorm Exchange. To provide a consistent code base across the packs, please apply the following recommendations to the submission:

  • Include a licence file. Apache 2.0 licenced code will be accepted for StackStorm packs.
  • Include a changelog in the format described here: https://keepachangelog.com/en/1.0.0/
  • Run black over Python code (action/sensors/test) with a line length of 100 characters.

Are you able to elaborate on what you mean by:

I am disallowing maintainer to edit this pack for security reasons. Please reach out to me if you guys want to change anything about this pack.

To be clear, by submitting the pack repository to the StackStorm Exchange, the StackStorm project maintainers will become the custodians of the code and will perform maintenance and apply patches.

You will be listed as a code owner, provide code reviews and have direct input on pull requests.

As a side note, we are working on moving the CI for the Exchange from CircleCI to Github, there will be delays before the pack will appear in the Exchange Index.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/StackStorm-Exchange/exchange-incubator/pull/169#issuecomment-954124493, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWCB2P4S5YGGO65TCERUT33UJGU2DANCNFSM5GMJDDMA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--

Yuri Dubler

Software Engineer

1.805.451.8565

820 State St, FI 1

Santa Barbara, CA 93101

http://www.logicmonitor.com

lm-ydubler commented 2 years ago

Closing pull request because our Pack has to be submitted by the official LogicMonitor Github Account (not this one).