search

StackStorm-Exchange / stackstorm-email

E-Mail Actions/Sensors for StackStorm
https://exchange.stackstorm.org/
Apache License 2.0
9 stars 45 forks source link

Remove account requirements #46

Open minsis opened 3 years ago

minsis commented 3 years ago

Fixes #45

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

minsis commented 2 years ago

Maybe? I thought a poller would only start if there was an associated rule trying to use it. So if you never created a rule to use it, the poller wouldn't start.

Also, there's already logic surrounding it:

https://github.com/StackStorm-Exchange/stackstorm-email/blob/ed66fd04c793dab3266f1fa0fe59c259981a7ce2/sensors/imap_sensor.py#L48

nzlosh commented 1 year ago

imap_accounts might be able to be made optional but smtp_accounts is a required part of the send_email code.

https://github.com/StackStorm-Exchange/stackstorm-email/blob/ed66fd04c793dab3266f1fa0fe59c259981a7ce2/actions/send_email.py#L18-L22