search

StackStorm-Exchange / stackstorm-excel

excel actions to read and write variables to an excel file
https://exchange.stackstorm.org/
Apache License 2.0
9 stars 8 forks source link

Feature request: Specify key column and variable columns separately #2

Open cognifloyd opened 7 years ago

cognifloyd commented 7 years ago

Please let me set the variable start and end columns separately from the key_column.

There's a spreadsheet that I don't maintain or produce. I need to look up values in columns A-I from that spreadsheet based on column J (key_column=10). However, actions as they are assume that the key_column comes first, and variable columns follow. So, with the current implementation I can only look up values in columns K+.

Currently the code sets _variable_start_column to key_column + 1 and then looks for the next cell in the header row that is blank, and sets _variable_end_column to one less than that blank column.

It shouldn't be too much work to add two more parameters variable_start_column and variable_end_column, and use those if they are set instead of the current logic.

Kami commented 7 years ago

This change request seems reasonable to me.

You can also get your hands dirty and look into contributing that change yourself :)