search

StackStorm-Exchange / stackstorm-excel

excel actions to read and write variables to an excel file
https://exchange.stackstorm.org/
Apache License 2.0
9 stars 8 forks source link

Update config.schema.yaml #5

Closed deterrak closed 6 years ago

deterrak commented 6 years ago

Stackstorm version 2.5 scheme seems to require a default value for each key. The excel_file var did not have a default set.

Here is the error that I saw after fresh install of the excel pack on Stackstorm version 2.5

root@EWC-v2:/opt/stackstorm/packs# st2 run excel.get_sheets excel_file='/home/stanley/firmwareVersions.xlsx'
.
id: 5a04acc0b2ee32071a790791
status: failed
parameters:
  excel_file: /home/stanley/firmwareVersions.xlsx
result:
  exit_code: 1
  result: None
  stderr: "Traceback (most recent call last):\n  File \"/opt/stackstorm/st2/local/lib/python2.7/site-packages/st2common/runners/python_action_wrapper.py\", line 259, in <module>\n    obj.run()\n  File \"/opt/stackstorm/st2/local/lib/python2.7/site-packages/st2common/runners/python_action_wrapper.py\", line 154, in run\n    action = self._get_action_instance()\n  File \"/opt/stackstorm/st2/local/lib/python2.7/site-packages/st2common/runners/python_action_wrapper.py\", line 229, in _get_action_instance\n    action_service=action_service)\n  File \"/opt/stackstorm/st2/lib/python2.7/site-packages/st2common/runners/utils.py\", line 85, in get_action_class_instance\n    action_instance = action_cls(**kwargs)\n  File \"/opt/stackstorm/packs/excel/actions/lib/excel_action.py\", line 20, in __init__\n    self._excel_file = self.config['excel_file']\nKeyError: 'excel_file'\n"
LindsayHill commented 6 years ago

Could you also bump the version in pack.yaml, and add an entry to CHANGES.md?