StackStorm-Exchange / stackstorm-kafka

Integration pack for Apache Kafka message broker
https://exchange.stackstorm.org/
Apache License 2.0
5 stars 11 forks source link

Fixes no attribute '__dict__' #9

Closed surfer190 closed 5 years ago

surfer190 commented 5 years ago

Per #6, the result ProduceResponse does not contain __dict__

This pull request changes the result to return _asdict()

Resolves #6 .

surfer190 commented 5 years ago

Tried to write a test...but had trouble mocking out all the python-kafka stuff.

Kami commented 5 years ago

Merged, thanks for the fix!

And yeah, sadly in some scenarios it's quite hard to write unit tests for the pack actions.