search

StackStorm-Exchange / stackstorm-kubernetes

st2 content pack containing Kubernetes sensors
https://exchange.stackstorm.org/
Apache License 2.0
19 stars 17 forks source link

proposal: git branch per kubernetes version #18

Open AndyMoore opened 6 years ago

AndyMoore commented 6 years ago

in order to differentiate between the variation in the apis of different kubernetes versions i propose to create a branch per kubernetes version

These would then be used in a pack install as

st2 pack install stackstorm-kubernetes=v1.5.7

Upside is being able to cover all versions of the api

Downside is versioning - where a bug is found and new packs must be generated do the versions get overwritten? or do we use v1.5.7-2 (or similar)?

these could then be merged into the the 'main branch', however this is a fair amount of admin for every change.. (could be scripted of course)

emptywee commented 6 years ago

I don't think API changes within one minor branch, e.g. thought all 1.6.x or 1.5.x versions of kubernetes. It'll probably make sense to have a branch for 1.5, 1.6, 1.7, 1.8 and so forth.

AndyMoore111 commented 6 years ago

ye that's a good shout too. also easier to manage