Fixed #28: Avoid empty strings in config files to be used as valid ones

StackStorm-Exchange / stackstorm-kubernetes

st2 content pack containing Kubernetes sensors

https://exchange.stackstorm.org/

Apache License 2.0

19 stars 17 forks source link

Fixed #28: Avoid empty strings in config files to be used as valid ones #29

Closed aletundo closed 5 years ago

aletundo commented 5 years ago

I strengthened the if conditions to check also for not empty string. In Python empty string are "falsy", so checking for a string to be True means it is not empty.

I also updated the README in order to clarify the config file fields, even though the code should be enough conservative now.

AndyMoore commented 5 years ago

Sorry for the delayed response, but if this is not also written to etc/st2packgen/ then it could be overwritten in the next release as the pack is generated

LindsayHill commented 5 years ago

@AndyMoore right you are of course. For some reason I didn't think this one came from the autogen code. Will update it.