search

StackStorm-Exchange / stackstorm-kubernetes

st2 content pack containing Kubernetes sensors
https://exchange.stackstorm.org/
Apache License 2.0
19 stars 17 forks source link

Query parameters not passed in URLs upon making API requests #39

Closed kgacheva closed 5 years ago

kgacheva commented 5 years ago

Currently, all actions in the StackStorm Kubernetes pack specify an arguments' dictionary args in which the parameters for the API requests are stored. The required path parameters (usually, the namespace and the name fields) are inserted in the corresponding URLs and further handled in the K8sClient base class upon making the request along with the body. However, the optional query parameters supported by the Kubernetes API are not consumed by the client and thus, not sent along with the request. As a result, the API requests do not include any data for the URL’s query string and are executed only with respect to the required parameters. It would be great if the query parameters are included in the request to the API with the purpose of restoring the established expected behavior for all actions.

kgacheva commented 5 years ago

40 fixes the handling of query parameters on making request to the Kubernetes API.

kgacheva commented 5 years ago

40 which fixes this problem has been merged. Closing this issue.