StackStorm-Exchange / stackstorm-st2

StackStorm pack management
https://exchange.stackstorm.org/
Apache License 2.0
5 stars 18 forks source link

Fix all actions which use client.query() method #4

Closed Kami closed 7 years ago

Kami commented 7 years ago

Fixes actions which use st2client query() method so they work again after a breaking change in https://github.com/StackStorm/st2/issues/3514 which has been included in v2.3.1.

In the future we need to be more careful when we do a breaking client changes like that one. We some how missed that breaking change and I believe we also didn't document it so we need to go back and explicitly document this in upgrade notes of st2 v2.3.

Resolves https://github.com/StackStorm/st2/issues/3606

LindsayHill commented 7 years ago

Hmmm. Problem with this one is that existing users need to manually run st2 pack install st2. Doesn't get done automatically on upgrade.

lakshmi-kannan commented 7 years ago

@LindsayHill I think the breaking change is now replaced with backward compatible API https://github.com/StackStorm/st2/pull/3616. I think we can close this PR? cc: @humblearner @Kami

Kami commented 7 years ago

Yep, closing :+1: