search

StackStorm-Exchange / stackstorm-zabbix

Apache License 2.0
16 stars 21 forks source link

Fixed a problem of the script to register st2 configuration to Zabbix and added an integration test for it. #29

Closed userlocalhost closed 5 years ago

userlocalhost commented 5 years ago

This fixed #28. Furthermore, this added an integration test of running tools/register_st2_config_to_zabbix.py with Zabbix v3.2 and v4.0.

userlocalhost commented 5 years ago

Sorry, I forgot to amend a version in pack.yaml and write a changelog. Please wait to merge it.

userlocalhost commented 5 years ago

to amend a version in pack.yaml and write a changelog.

It's done.

arm4b commented 5 years ago

Integration test looks very solid :+1:

I'm now wondering why CircleCI doesn't show the build status for the commited PR changes. Guessing it's something related to https://github.com/StackStorm-Exchange/stackstorm-zabbix/pull/29/checks, - I've seen something similar when enabling new Github "checks" feature that stopped the CircleCI builds to show up. Will try something to fix it.

userlocalhost commented 5 years ago

I'm now wondering why CircleCI doesn't show the build status for the commited PR changes.

Sorry, It's my fault. I set configuration of CircleCI to follow forked repository (userlocalhost/stackstorm-zabbix). When forked repository was followed, the test of PR seems not to be run.

After I unregistered to following forked repository in CircleCI, then it works well.