search

StackStorm / ansible-st2

Ansible Roles and Playbooks to deploy StackStorm
https://galaxy.ansible.com/StackStorm/stackstorm/
Apache License 2.0
100 stars 75 forks source link

Add new 2.9 service: timersengine #201

Closed cognifloyd closed 6 years ago

cognifloyd commented 6 years ago

Add new 2.9 service: timersengine

Resolves #196

cognifloyd commented 6 years ago

I don't understand the test results. On systemd systems this passes, but the idempotence check fails on sysv/upstart because the st2workflowengine and st2timersengine both report changed every time they're requested to start. Why don't they stay running?

Also, what's up with the extra entry in CentOS 6? When adding the workflow_engine and timersengine sections, it reports an extra changed line that is apparently set to no_log. Only CentOS 6 does this, none of the other platforms do.

cognifloyd commented 6 years ago

I'll drop the rest for now.

I'm surprised upgrading isn't supported as this is in the readme:

st2_version | latest | StackStorm version to install. present to install available package, latest to get automatic updates, or pin it to numeric version like 2.2.0.

So, installing st2 via ansible supports automatic updates but not upgrades?

cognifloyd commented 6 years ago

dropped upgrade logic and rebased on #200.

arm4b commented 6 years ago

That's a good and a valid question.

For Ansible I think we tend to follow slightly more simplified approach comparing to traditional Chef or Puppet ways. It's a tradeoff we have to do balancing between complexity vs able to support it. Apart of this migration scenarios there were more tough corner cases. If we add a few migrations today and don't support future migrations that would be not consistent.

I'll look at this PR in more detail later post 2.9 release. In a meantime, can you please create a new PR just for adding st2timersengine similar to https://github.com/StackStorm/ansible-st2/pull/198?

cognifloyd commented 6 years ago

I have a copy of the upgrade logic saved in a separate branch. This is now just the timersengine change.