search

StackStorm / ansible-st2

Ansible Roles and Playbooks to deploy StackStorm
https://galaxy.ansible.com/StackStorm/stackstorm/
Apache License 2.0
100 stars 75 forks source link

added ability to install ST2 packs #230

Closed guymatz closed 5 years ago

guymatz commented 5 years ago

set st2_packs to have them installed. This should be a module, but this is good enough for now

arm4b commented 5 years ago

In a meantime, don't worry about CI, - they're not related to your change, something new from upstreams. I'll look at them in another PR.

arm4b commented 5 years ago

Just fixed some upstream linting CI issues, not related to your PR.

Now CI is signalizing real failures coming from this PR. I advised some changes and improvements above ^^ so we can merge it. @guymatz Let us know if you're interested/have capacity to finish this contribution.

guymatz commented 5 years ago

Hi! I would like to put something like this in smoketests:

but it looks like there's a task in smoktests to install the st2 pack . . . is it still a valid test of the playbook?

On Mon, Feb 25, 2019 at 1:53 PM Eugen C. notifications@github.com wrote:

Just fixed some upstream linting CI issues, not related to your PR.

Now CI is signalizing real failures coming from this PR. I advised some changes and improvements above ^^ so we can merge it. @guymatz https://github.com/guymatz Let us know if you're interested/have capacity to finish this contribution.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/StackStorm/ansible-st2/pull/230#issuecomment-467133848, or mute the thread https://github.com/notifications/unsubscribe-auth/ABnFWFoficfvZ_Q8hlJ9HcJXnUM_Xtz_ks5vRDERgaJpZM4bBdwq .

arm4b commented 5 years ago

Yes. We can install st2 pack by default by having st2_packs: [st2] in Ansible defaults and check if it's present during the smoke tests, as you wanted.

Having st2 pack installed in default installation is something that we follow in other deployment methods so this approach should be consistent.