Ensure st2.conf values are not converted to particular structure

StackStorm / ansible-st2

Ansible Roles and Playbooks to deploy StackStorm

https://galaxy.ansible.com/StackStorm/stackstorm/

Apache License 2.0

100 stars 75 forks source link

Ensure st2.conf values are not converted to particular structure #234

Closed arm4b closed 5 years ago

arm4b commented 5 years ago

Closes #238

Covers edge case when user wants to set in st2.conf json-formatted value which might be converted to particular structure during the jinja/ansible pipeline.

See https://github.com/StackStorm/ansible-st2/issues/156

Kami commented 5 years ago

LGTM.

How hard would it be to add tests for it?

arm4b commented 5 years ago

That would be not that easy and bring insufficient value comparing to increasing the build timing and tests complexity. Ansible plays we have are designed to be simple and have only smoke tests instead of checking all the permutations of possible configurations. It's the best effort we can do and is good enough, considering ongoing development/maintenance of many other projects.