StackStorm / ansible-st2

Ansible Roles and Playbooks to deploy StackStorm
https://galaxy.ansible.com/StackStorm/stackstorm/
Apache License 2.0
100 stars 75 forks source link

Include centos 7 in condition for installing st2 pack in smoketests #252

Closed surfer190 closed 4 years ago

surfer190 commented 4 years ago

Attempts to fix #251

I have not added any tests.

I am also unsure why there is a condition just for red hat version 6 to install the st2 pack but the next task to Verify if st2 pack was installed has no such condition.

arm4b commented 4 years ago

The reason we exclude EL6 from some of the tasks comes from the fact that specific Ansible/Jinja functionality we need is not possible in EL6. See https://github.com/StackStorm/ansible-st2/pull/250 for more info.

Smoketests with pack install are trying to test default st2_packs: [st2] when st2 pack is installed during the StackStorm.st2 role run.

surfer190 commented 4 years ago

Ok @armab updated. Why couldn't I just approve your changes from here? Anyway made the change again in my fork and pushed.