search

StackStorm / ansible-st2

Ansible Roles and Playbooks to deploy StackStorm
https://galaxy.ansible.com/StackStorm/stackstorm/
Apache License 2.0
100 stars 75 forks source link

Unpin rabbitmq #291

Closed amanda11 closed 3 years ago

amanda11 commented 3 years ago

Stop pinning version of rabbitmq on EL8.

Install latest from packagecloud, and therefore as that requires newer version of erlang, install the minimal erland provided by rabbitmq - as per instructions at https://github.com/rabbitmq/erlang-rpm

Relates to https://github.com/StackStorm/st2-packages/pull/699

Kami commented 3 years ago

I personally still pinning to a specific is a good idea / best practice to avoid surprises due to major version changes or similar and ensure reproducibility.

But otherwise change looks good to me :+1:

amanda11 commented 3 years ago

If we want to pin version we should probably do it across the board - on all installers, and define version for each OS. I've left in the functionality so that you can still the pin the version if you desired - as I figured that was worth keeping.

@Kami What about if I create a generic issue under ST2 to add in support to pin rabbitmq version, as if we do it we should consider it for all OS and all installers, and make sure that we keep all install methods and docs etc using same version? As I think its a bigger issue than just this EL8 ansible problem.

Kami commented 3 years ago

@amanda11

If we want to pin version we should probably do it across the board - on all installers, and define version for each OS. I've left in the functionality so that you can still the pin the version if you desired - as I figured that was worth keeping.

Yeah, in this case it's fine for now.

@Kami What about if I create a generic issue under ST2 to add in support to pin rabbitmq version, as if we do it we should consider it for all OS and all installers, and make sure that we keep all install methods and docs etc using same version? As I think its a bigger issue than just this EL8 ansible problem.

Yeah, imo that would be ideal long term scenario.

Technically, we already kinda (unintentionally) do that for some software - e.g. MongoDB which uses different apt repo per major version. And for RabbitMQ as well (to some extent) since we rely on default upstream versions which usually don't ship all the most recent major versions (which is now not true for the RabbitMQ apt repo anymore).

Kami commented 3 years ago

st2vagrantdev change (confirmed working locally) - https://github.com/StackStorm/st2vagrantdev/pull/10