StackStorm / ansible-st2

Ansible Roles and Playbooks to deploy StackStorm
https://galaxy.ansible.com/StackStorm/stackstorm/
Apache License 2.0
100 stars 77 forks source link

Install gpg before calling apt_key #305

Closed mamercad closed 2 years ago

mamercad commented 2 years ago

Fixes #304 (at least the first problem).

mamercad commented 2 years ago

These two changes get me through the installation (on Focal, at least):

PLAY RECAP ******************************************************************************************************************
stackstorm                 : ok=86   changed=0    unreachable=0    failed=0    skipped=63   rescued=0    ignored=1
mamercad commented 2 years ago

I don't see how these changes could cause the failures that I'm seeing in the integration tests... I'll dig deeper when I get a chance.

mamercad commented 2 years ago

Hrm, I was able to vagrant up ubuntu18 and vagrant up ubuntu20 without issue, probably going to need some help understanding why the integrations tests are failing.

mamercad commented 2 years ago

Thanks for the PR! 👍

Everything looks good, just left one minor comment.

The failure is irrelevant to your PR as it breaks on the chatops tests. We recently switched the CI system and looks like the GH Actions is not passing some chatops secret used in tests to the forked builds. We'll try to fix that in another PR.

Sweet, thanks for the help; I was surely confused since things were working locally (with Vagrant).