StackStorm / ansible-st2

Ansible Roles and Playbooks to deploy StackStorm
https://galaxy.ansible.com/StackStorm/stackstorm/
Apache License 2.0
100 stars 77 forks source link

Linting all the things #326

Closed mamercad closed 1 year ago

mamercad commented 1 year ago

Currently, on master, this is what the summary looks like:

                              Rule Violation Summary                              
 count tag                    profile    rule associated tags                     
    13 jinja[spacing]         basic      formatting (warning)                     
    12 role-name              basic      deprecations, metadata (warning)         
    12 schema[meta]           basic      core, experimental (warning)             
     3 name[missing]          basic      idiom                                    
     5 name[template]         moderate   idiom                                    
    43 name[casing]           moderate   idiom (warning)                          
    26 risky-file-permissions safety     unpredictability, experimental (warning) 
     4 ignore-errors          shared     unpredictability, experimental (warning) 
     1 meta-no-tags           shared     metadata                                 
   162 fqcn[action-core]      production formatting                               
    19 fqcn[action]           production formatting (warning)                     

Failed after min profile: 171 failure(s), 129 warning(s) on 106 files.

On this branch, the summary looks like this:

                        Rule Violation Summary                        
 count tag           profile rule associated tags                     
    12 role-name     basic   deprecations, metadata (warning)         
     1 ignore-errors shared  unpredictability, experimental (warning)
arm4b commented 1 year ago

Setting the breaking change tag here, if we want to update the min ansible version and more following that.

Sounds like it can also close the https://github.com/StackStorm/ansible-st2/issues/242 ?

mamercad commented 1 year ago

Setting the breaking change tag here, if we want to update the min ansible version and more following that.

Sounds like it can also close the #242 ?

Yep, I think so, we should strive for at least ansible-core 2.13 (that gives us about a year of security and bug fixes).

mamercad commented 1 year ago

Closed in favor of ansible-lint --write down the road.