Moving to packaging.

[sysbot]

Per [1], packages are now installed via Packagecloud instead of from source. Related python/git/build and pip recipes are removed in favor of virtualenv packages.

[1] https://stackstorm.com/2016/05/03/road-to-packages/

[Kami]

Awesome, nice work :+1:

Did you happen to have a chance to test those changes end to end and verify that everything works? I'm just wondering because this repo was quite out of date and it's possible that some other things also need to be updated / changed :)

[sysbot]

I haven't tested every code path but the full convergence is working as is, assuming stmistral get merged first. For the rest of the code paths I recommend adding Inspec/Unit tests.

[dennybaa]

Generally there's a lot of outdated code for components (one package like st2actions contains several services) it should be reworked since now it's only one bundle package. Second thing is that the stackstorm_service LWRP actually is not needed and should be deprecated since all the packages come with built-in service files, the services should be just started after configuration takes place....

[dennybaa]

@sysbot This is nice you decided to tackle it, thank you! It would be nice if you could also cover the mentioned issues.

[shortdudey123]

@dennybaa

Second thing is that the stackstorm_service LWRP actually is not needed

I don't see any LWRP's in this cookbook (I do see a StackstormCookbook::RecipeHelpers. stackstorm_service method, not sure if thats what you are talking about)

[sysbot]

Yeah im a bit curious about the stackstorm_service bit, I'll work out something (or remove) and add a commit.

[sysbot]

In regard to the components, it seemed that the installation guide is also out-of-date, for api service it suggested sudo st2ctl restart-component st2api but that's not the case anymore as demonstrated here.

vagrant@default-ubuntu-1404:/etc/init.d$ sudo st2ctl restart-component st2api
initctl: Unknown instance:
vagrant@default-ubuntu-1404:/etc/init.d$ sudo service st2api restart
stop: Unknown instance:
st2api start/running, process 22552

[sysbot]

Let me know if there's anything else you want to see fix here. Thanks.

[shortdudey123]

@sysbot can you rebase on master?

[sysbot]

@shortdudey123 I've added the rubocop fixes as well. Let me know if this is good to merge. Thanks.

[shortdudey123]

can you add this to the correct spot in .rubocop.yml due to the newest release? Unless @Kami thinks rubocop's defaults should be followed

Style/NumericLiteralPrefix:
  Description: 'Use smallcase prefixes for numeric literals.'
  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#numeric-literal-prefixes'
  EnforcedOctalStyle: zero_only
  Enabled: true

Also, can you fix the other error? libraries/recipe_helpers.rb:16:5: W: Lint/UselessAccessModifier: Useless private access modifier.

[sysbot]

@shortdudey123 fixed.

[Kami]

@sysbot Since you are more active on this repository then we are these days (we are busy with advancing the core platform and other things), I just gave you direct commit privileges to this repo (you should receive an invite to your email address).

Feel free to directly merged changes you think are good to the repository, but it would still be good if you create a PR for each change so other people can more easily see what is happening and chime in if they get a chance :)

[sysbot]

@Kami thanks for the invite. Yup will do PR and solicit for comments as normal.

[shortdudey123]

looking good to me :)

[sysbot]

Just double check and successfully converge in test-kitchen still. Merging.