search

StackStorm / chef-stackstorm

DEPRECATED! Community-maintained Chef Cookbook to deploy StackStorm, IFTTT for Ops
https://supermarket.chef.io/cookbooks/stackstorm
Apache License 2.0
16 stars 10 forks source link

Run Kitchen-Docker in TravisCI #22

Closed jvrplmlmn closed 7 years ago

jvrplmlmn commented 8 years ago

Tests for CentOS will fail until https://github.com/StackStorm/chef-stackstorm/pull/16 gets merged.

Solves #17

@shortdudey123 @sysbot @armab ?

shortdudey123 commented 8 years ago

how about we not remove all the other testing :)

jvrplmlmn commented 8 years ago

@shortdudey123 added back rubocop, foodcritic and rspec.

The Kitchen tests are failing for apparently unrelated issues.

jvrplmlmn commented 8 years ago

https://stackstorm-community.slack.com/archives/community/p1474226956001831

shortdudey123 commented 8 years ago

Since logrotate is included in the base install of CentOS and Ubuntu but evidently not the docker images, you should be able to just add it to the provision_command section and call it good

jvrplmlmn commented 7 years ago

Ran kitchen locally and the converge phase fails on the Ubuntu 14.04 box due to issues with the packagecloud repos:

(...)
Hit http://archive.ubuntu.com trusty/restricted amd64 Packages
Hit http://archive.ubuntu.com trusty/universe amd64 Packages
Get:2 https://packagecloud.io trusty/main Sources
Fetched 16.8 kB in 10s (1552 B/s)
W: Failed to fetch https://packagecloud.io/StackStorm/stable/ubuntu/dists/trusty/main/source/Sources  Hash Sum mismatch

W: Failed to fetch https://packagecloud.io/StackStorm/stable/ubuntu/dists/trusty/main/binary-amd64/Packages  Hash Sum mismatch

E: Some index files failed to download. They have been ignored, or old ones used instead.
(...)

@emedvedev ?

shortdudey123 commented 7 years ago

@jvrplmlmn see http://blog.packagecloud.io/eng/2016/03/21/apt-hash-sum-mismatch/

jvrplmlmn commented 7 years ago

@shortdudey123 @sysbot @armab this is up for review. Let me know if you want me to squash the commits.

arm4b commented 7 years ago

Thanks @jvrplmlmn for contributing and @shortdudey123 for reviewing, this is nice feature to have indeed!

Green build looks good enough to me :+1: but @shortdudey123 and @sysbot might have better idea about details.

arm4b commented 7 years ago

Since the build works in Travis, I think I'll go ahead and merge it to benefit from this PR. We can change the small things afterwards.

arm4b commented 7 years ago

Also, I'd change Docker images to those we already use for testing environment (shipped with init systems). See: https://github.com/StackStorm/ansible-st2/blob/master/.kitchen.yml#L24-L39 https://hub.docker.com/r/stackstorm/packagingtest/tags/

@shortdudey123 Feel free to do after-merge changes as well.

arm4b commented 7 years ago

Seeing now how helpful it is, would like to say big Thank You to @jvrplmlmn :tada: for implementation :+1: