Add chefspec testing

[arm4b]

Nice :+1:

You can also find some spec here: https://github.com/StackStorm/st2-packages/blob/master/rake/spec/default/

Ex. build log example:

[shortdudey123]

Fixed travis failures :)

[arm4b]

Since I'm not ruby/Chef guy, I can only assume what's going on here :)

@shortdudey123 Can you describe at a high level how these integration tests are executed? For example what platform is actually tested and how? Is it isolated with test-kitchen + Docker or it's executed directly in Travis environment?

[shortdudey123]

These are chef specific rspec tests that verify the chef resources do what the are supposed to do. test-kitchen is not involved since these are unit tests and not integration tests.

[arm4b]

since these are unit tests and not integration tests.

That's what I got wrong. Makes sense now, thanks!

[arm4b]

:+1:

@Kami, @sysbot please take a look

[Kami]

Nice work :+1:

Thanks!

[Kami]

@shortdudey123 I also gave you a direct write / collaborator access to this repository since you are more active than us in this repository

Even though you have a direct access, please still follow "best" practices for contributing (open a PR so it's easier to see what has been changed and so other can chime in, etc.), but also feel free to merge those PRs at your discretion.

[shortdudey123]

@Kami cool, thanks!!!

@sysbot can you review this as well since it is testing on your rewrite?

[sysbot]

@shortdudey123 these are awesome! test-kitchen for integration testing in the future would even be better. LGTM.

[shortdudey123]

yup, test-kitchen stuff is next on the todo list