StackStorm / chef-stackstorm

DEPRECATED! Community-maintained Chef Cookbook to deploy StackStorm, IFTTT for Ops
https://supermarket.chef.io/cookbooks/stackstorm
Apache License 2.0
16 stars 10 forks source link

poise-python branch no longer exists! #4

Closed jhull123 closed 7 years ago

jhull123 commented 8 years ago

This cookbook's Berksfile references a branch of chef-openstack-mistral that doesn't exist.

cookbook 'openstack-mistral', git: 'git://github.com/sysbot/chef-openstack-mistral.git', branch: 'poise-python'

What gives?

shortdudey123 commented 8 years ago

@sysbot can you look at this? Looks like it got added in https://github.com/StackStorm/chef-stackstorm/commit/582fa87c8d75d68450c6e55fc16bb4a6b5f70f84#diff-b22b9fdef9829890209682dd271cccb3

sysbot commented 8 years ago

That branch does still exist but needed to be merge per https://github.com/StackStorm/chef-openstack-mistral/pull/2. I will PR to fix this bug and wait for https://github.com/StackStorm/chef-openstack-mistral/pull/2 to be merge for this new package to work properly.

sysbot commented 8 years ago

Darn i accidentally pushed to Master with https://github.com/StackStorm/chef-stackstorm/commit/d37754964b57068f0e420cb5fb6e9777d1db7946 thinking I was on a branch. Let me know if it's an issue I can revert and PR.

shortdudey123 commented 8 years ago

@sysbot this can probably be closed since you pushed https://github.com/StackStorm/chef-stackstorm/commit/d37754964b57068f0e420cb5fb6e9777d1db7946 correct?

sysbot commented 8 years ago

Yes this can be close if no issues with the accident direct push.

shortdudey123 commented 8 years ago

sounds good

shortdudey123 commented 8 years ago

@sysbot looks like https://github.com/StackStorm/chef-openstack-mistral/pull/2/files has not been merged, so https://github.com/StackStorm/chef-stackstorm/commit/d37754964b57068f0e420cb5fb6e9777d1db7946 does not currently work. Can you pull it back out? fix the rubocop violations, and open a PR? then we can merge it once the PR is merged

shortdudey123 commented 7 years ago

Partially solved with https://github.com/StackStorm/chef-stackstorm/pull/6 and will be completely solved when https://github.com/StackStorm/chef-openstack-mistral/issues/3 is completed

shortdudey123 commented 7 years ago

Both https://github.com/StackStorm/chef-stackstorm/pull/6 and https://github.com/StackStorm/chef-openstack-mistral/issues/3 were completed