StackStorm / chef-stackstorm

DEPRECATED! Community-maintained Chef Cookbook to deploy StackStorm, IFTTT for Ops
https://supermarket.chef.io/cookbooks/stackstorm
Apache License 2.0
16 stars 10 forks source link

platform_version in Travis #44

Closed arm4b closed 7 years ago

arm4b commented 7 years ago

In Travis we see confusing platform_version when running ChefSpec unit tests. It's not clear what that really means.

After some research, here is what is platform_version and how it should be:

Example found in mysql chef cookbook:

So it might be good to follow that example by running unit tests with different platform settings and remove platform hardcoding from spec_helper.rb

shortdudey123 commented 7 years ago

nice find!

shortdudey123 commented 7 years ago

Looks like yum-erlang_solutions is the one causing the platform_version output as well as the deprecation warnings

shortdudey123 commented 7 years ago

Solved by https://github.com/chef-cookbooks/yum-erlang_solutions/pull/11

arm4b commented 7 years ago

Good catch!

shortdudey123 commented 7 years ago

PR merged on the yum-erlang_solutions side Should be picked up in the next supermarket release

shortdudey123 commented 7 years ago

Looks like it was already released https://github.com/chef-cookbooks/yum-erlang_solutions/commit/168e72b0d14bf2e20a7d5de960098a444263d1a8

Restarted the master branch build on travis and it cleaned up the extra output https://travis-ci.org/StackStorm/chef-stackstorm/jobs/179058632

arm4b commented 7 years ago

Yay! Thanks @shortdudey123, looks much cleaner now :+1:

I renamed the Issue just not to open another one, related to multi-platform Unit Testing.

But you can close this Issue as "resolved" & open another one with the correct description, if you want.