search

StackStorm / chef-stackstorm

DEPRECATED! Community-maintained Chef Cookbook to deploy StackStorm, IFTTT for Ops
https://supermarket.chef.io/cookbooks/stackstorm
Apache License 2.0
16 stars 10 forks source link

Remove `--always-copy` >=EL7 #77

Open punkrokk opened 4 years ago

punkrokk commented 4 years ago

The below two files needs the virtualenv_opts = --always-copy line either commented out or the value removed.

This needs validation. If https://github.com/StackStorm/st2/pull/4891 is merged, we can assume it's a go.

https://github.com/StackStorm/chef-stackstorm/blob/2aa543bbb19df1c176299aea22828d7a6e6e41a6/spec/recipes/config_spec.rb#L30-L32

https://github.com/StackStorm/chef-stackstorm/blob/2aa543bbb19df1c176299aea22828d7a6e6e41a6/spec/recipes/config_spec.rb#L30:L32

arm4b commented 4 years ago

A little bit more context.

Per https://github.com/StackStorm/st2/pull/4891 note that --always-copy flag should be removed for both EL7 and EL8 as it breaks virtualenv for pack install in these systems. However should exist for all other systems: currently EL6, U14, U16, U18.

This virtualenv_opts adjustment is automatically done by the packaging, however applying and templating custom st2.conf as it's done in chef-stackstorm breaks it.

cc @nmaludy Please check if there is a similar issue with the Puppet module or whether st2.conf templating happens there too.

nmaludy commented 4 years ago

@armab Doesn't appear to be an issue in the Puppet module. In Puppet we use the ini_setting resource and edit individual pieces instead of templating the whole file (for now).