search

StackStorm / hubot-stackstorm

Hubot plugin for integration with StackStorm event-driven infrastructure automation platform.
Apache License 2.0
49 stars 39 forks source link

Add rocketchat #135

Closed cheremushki closed 7 years ago

cheremushki commented 7 years ago

Add support for RocketChat.

cheremushki commented 7 years ago

No thoughts/comments guys?

LindsayHill commented 7 years ago

@cheremushki we're not deliberately ignoring you! I know @bigmstone has GH reviews on his list of things to do. Should get done soon

arm4b commented 7 years ago

Related to https://github.com/StackStorm/st2/issues/3352

JSzaszvari commented 7 years ago

How did I miss this awesomeness!

Great work. Going to try it out in my test environment.

JSzaszvari commented 7 years ago

Been using this now for just over a week and working great!

screen shot 2017-07-27 at 2 00 25 am

Get some nice formatting back instead of a wall of plaintext

JSzaszvari commented 7 years ago

This change could potentially break any sort of RC / Slack Clone functionality - https://github.com/StackStorm/hubot-stackstorm/pull/138

Although I'm still investigating how it could be avoided.

cheremushki commented 7 years ago

I'll take a look at refactoring as per the requested changes when I have some time.

cheremushki commented 7 years ago

Reordered the formatters to allow easier code review as requested. Raised https://github.com/StackStorm/st2chatops/pull/88

arm4b commented 7 years ago

Thanks @cheremushki! Will try it soon.