StackStorm / hubot-stackstorm

Hubot plugin for integration with StackStorm event-driven infrastructure automation platform.
Apache License 2.0
49 stars 39 forks source link

Add ability to specify stream URL #144

Closed shusugmt closed 7 years ago

shusugmt commented 7 years ago

Solves #143

LindsayHill commented 7 years ago

@armab I think that dropping nodejs 0.12 tests makes sense. (https://github.com/StackStorm/hubot-stackstorm/pull/144/commits/d6092198162bc008b059adb5a3fa33b69296a64c). What do you think?

Kami commented 7 years ago

Change looks good to me :+1:

/cc @armab

shusugmt commented 7 years ago

@armab Thanks for review.

CHANGELOG update mentioning:

  • dropping node.js 0.12 support
  • updating st2client to 1.1.1
  • adding ST2_STREAM_URL

I thought this should be done in release commit? like:

arm4b commented 7 years ago

The previous changes went into Changelog in one commit because there was nothing else to add (1 change = 1 release). In case of more changes, - it's preferred to include what was done in the changelog as part of PR. Would be easy for release manager so he don't need to grab the git history.

This is similar to what we do in StackStorm/st2, ex: https://github.com/StackStorm/st2/pull/3849/files

shusugmt commented 7 years ago

@armab changelog updated!

arm4b commented 7 years ago

Merged, Thanks!