search

StackStorm / orquestaconvert

Converts Mistral workflows into Orchestra workflows
Apache License 2.0
13 stars 7 forks source link

Convert task names #11

Closed blag closed 6 years ago

blag commented 6 years ago

Orquesta does not handle dashes in task names, so this translates dashes to underscores in task names.

Note that this does not check for collisions, however the documentation has been strongly recommending against using dashes for quite some time and having two different tasks whose names differ only in the use of dashes vs. underscores would be weird:

tasks:
  odd-job:
    ...  # Bond
  odd_job:
    ...  # James Bond
  random-task:
    ...  # Powers
  random_task:
    ...  # Austin Powers

so collisions created by this should be exceptionally rare.

codecov-io commented 6 years ago

Codecov Report

Merging #11 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage    99.7%   99.71%   +<.01%     
==========================================
  Files           9       10       +1     
  Lines         343      353      +10     
==========================================
+ Hits          342      352      +10     
  Misses          1        1
Impacted Files Coverage Δ
orquestaconvert/utils/task_utils.py 100% <100%> (ø)
orquestaconvert/workflows/base.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 444f535...bfd4bcf. Read the comment docs.