search

StackStorm / orquestaconvert

Converts Mistral workflows into Orchestra workflows
Apache License 2.0
13 stars 7 forks source link

Tweak on-complete publishing semantics to fit Orquesta publishing paradigm #22

Closed blag closed 5 years ago

blag commented 5 years ago

Mistral has a single task context that tasks can publish into. Orquesta contexts are passed from task to downstream tasks, so downstream tasks cannot access published variables that were not published in tasks in their transition chain.

Due to the different context semantics, we need to explicitly publish the publish and publish-on-error variables for tasks transitioned to with on-complete.

However, this isn't a simple task because it requires merging two publish dictionaries (publish and publish-on-error).

I also add and update tests and fixtures.

codecov-io commented 5 years ago

Codecov Report

Merging #22 into master will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage   98.67%   98.69%   +0.02%     
==========================================
  Files          12       12              
  Lines         604      615      +11     
==========================================
+ Hits          596      607      +11     
  Misses          8        8
Impacted Files Coverage Δ
orquestaconvert/workflows/base.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b00a80f...8d26da6. Read the comment docs.