Deploy artifacts to github releases

StackStorm / packer-st2

Packer templates for building & deploying Vagrant & OVA with StackStorm installed

https://app.vagrantup.com/stackstorm/boxes/st2

Apache License 2.0

14 stars 7 forks source link

Deploy artifacts to github releases #25

Closed warrenvw closed 6 years ago

warrenvw commented 6 years ago

Closes #9.

Remaining packer-st2 CI tasks

[x] Add GITHUB_TOKEN to packer-st2 CircleCI environment
[x] Change .circleci/config.yml such that a non-tagged build will result in the deploy-ova job NOT being executed.
[x] Call ghr tool in deploy-ova job, providing CIRCLE_PROJECT_USERNAME, CIRCLE_PROJECT_REPONAME and CIRCLE_TAG.
[x] Change .circleci/config.yml such that a tagged build will result in the deploy-ova job being executed.

Remaining test tasks

[x] Test pushing a tag results in build artifacts being deployed to GitHub release page.

arm4b commented 6 years ago

Please remove the # TODO: In a future PR, deploy artifact to S3. from the CircleCI config, - we don't need it in this repo.

arm4b commented 6 years ago

Hm, curious why it's running the deploy-ova (and failing there) after removing the branch config from CircleCI in favor of tag-only.

warrenvw commented 6 years ago

Looks like it was the CircleCI native git that messed things up in my earlier tests.. once I used an image with git installed, the deploy started working properly. Woot!

In summary, the deploy-ova job is only executed for a tag push. A branch push does not result in this job being executed.

arm4b commented 6 years ago

Great work :+1: Just left one minor comment.

warrenvw commented 6 years ago

Okay. I'll address in another PR.