Closed arm4b closed 6 years ago
9000 is an odd port to use. More common to use something like 8443 for an HTTPS service if you're not going to use 443.
Yes, not going to use 443
since it has high chances to conflict with any existing host ports.
In fact, it's a bad practice in Vagrant community to automatically port-forward anything by default via (parent) box Vagrantfile, except of SSH (2222). Especially when it could conflict with user's Vagrantfile networking or host's existing ports so I'm not sure about this PR and postponed it for now as "optional'.
I guess the main thing is that the user will want to be able to login to the Web UI. We have to make sure that the default Vagrant/Virtualbox configuration makes this easy.
I'm OK with the way we currently do it in github.com/StackStorm/st2vagrant, where we have a hard-coded IP. That at least makes documentation easy, and we're not forwarding ports, so that side should be OK.
Obviously a potential clash with someone using that network for something else, but there's a limit to what we can do here
Setting an IP/Network is even more destructive, comparing to port forwarding. Note that we're setting it in "parent" Vagrantfile which ideally should have less unexpected/surprising changes as possible. User won't even have idea where these settings are coming from.
Ideally these settings should be set manually by user in his init'd Vagrantfile.
Alright, let's try it and hope for good :crossed_fingers:
Alright, here is how it'll work and look like:
Closes #28
Make StackStorm web UI available via ~
https://127.0.0.1:9000/
~https://10.10.10.10/
for the host machine.TODO: