StackStorm / st2-auth-ldap

LDAP backend for user authentication in StackStorm. Previously LDAP backend for EWC.
https://docs.stackstorm.com/authentication.html
Apache License 2.0
5 stars 12 forks source link

renamed st2auth_enterprise_ldap_backend To st2auth_ldap #77

Closed sagar-orchestral closed 4 years ago

sagar-orchestral commented 4 years ago

Made changes in packages. Please review PR Below are the chane in packages. .travis.yml Makefile setup.py tests/integration/test_active_directory.py tests/integration/test_openldap.py tests/unit/test_backend.py tests/unit/test_config.py tox.ini

m4dcoder commented 4 years ago

There're two errors in the travis CI job.

For the error python3.6 task below, you will have to add isort<=4.0.0 to test-requirements.txt to get around the issue.

$ pylint -E --rcfile=./lint-configs/python/.pylintrc st2auth_ldap/
515Using config file /home/travis/build/StackStorm/st2-auth-ldap/lint-configs/python/.pylintrc
516Traceback (most recent call last):
517  File "/home/travis/virtualenv/python3.6.7/bin/pylint", line 8, in <module>
518    sys.exit(run_pylint())
519  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/pylint/__init__.py", line 16, in run_pylint
520    Run(sys.argv[1:])
521  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/pylint/lint.py", line 1353, in __init__
522    linter.check(args)
523  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/pylint/lint.py", line 774, in check
524    self._do_check(files_or_modules)
525  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/pylint/lint.py", line 907, in _do_check
526    self.check_astroid_module(ast_node, walker, rawcheckers, tokencheckers)
527  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/pylint/lint.py", line 986, in check_astroid_module
528    walker.walk(ast_node)
529  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/pylint/utils.py", line 1016, in walk
530    cb(astroid)
531  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/pylint/checkers/imports.py", line 443, in leave_module
532    std_imports, ext_imports, loc_imports = self._check_imports_order(node)
533  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/pylint/checkers/imports.py", line 588, in _check_imports_order
534    isort_obj = isort.SortImports(
535AttributeError: module 'isort' has no attribute 'SortImports'
536The command "pylint -E --rcfile=./lint-configs/python/.pylintrc st2auth_ldap/" exited with 1.

For the error in the python2.7 task, here's the output. I don't know what the fix should be. Can you figure out?

Collecting st2-auth-backend-flat-file
270  Downloading st2-auth-backend-flat-file-0.1.0.tar.gz (5.1 kB)
271    ERROR: Command errored out with exit status 1:
272     command: /home/travis/virtualenv/python2.7.15/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-YtZ1VY/st2-auth-backend-flat-file/setup.py'"'"'; __file__='"'"'/tmp/pip-install-YtZ1VY/st2-auth-backend-flat-file/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-2kAMYk
273         cwd: /tmp/pip-install-YtZ1VY/st2-auth-backend-flat-file/
274    Complete output (7 lines):
275    Traceback (most recent call last):
276      File "<string>", line 1, in <module>
277      File "/tmp/pip-install-YtZ1VY/st2-auth-backend-flat-file/setup.py", line 32, in <module>
278        install_reqs, dep_links = fetch_requirements(REQUIREMENTS_FILE)
279      File "dist_utils.py", line 74, in fetch_requirements
280        if req.link:
281    AttributeError: 'ParsedRequirement' object has no attribute 'link'
282    ----------------------------------------
283ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
284The command "pip install -r test-requirements.txt -r requirements.txt" failed and exited with 1 during .
m4dcoder commented 4 years ago

Duplicate of https://github.com/StackStorm/st2-auth-ldap/pull/83