account for unique user group

StackStorm / st2-packages

StackStorm deb/rpm packages (automated docker build pipeline)

https://stackstorm.com/

27 stars 59 forks source link

account for unique user group #664

Open lattisimo opened 3 years ago

lattisimo commented 3 years ago

Use id -gn to get the user group for curl|bash stackstorm installer.

The issue I had was installing on a box that had LDAP configured and my user group is 'domain users' since the script just assumed the group matched the user so the chown command fails and the script stops executing. I can avoid the issue by 'sudo su' but I realized that if I get the user's group with 'id -gn' then there is no assumption of what that value should be. This would likely be relevant on the other scripts.

arm4b commented 3 years ago

@lattisimo Would be good to know the more context around this issue: what led you to this solution, what's the issue, error message, etc.

lattisimo commented 3 years ago

Since this is my first interaction of this sort. I want to follow up if there is any additional action needed on my part? I am not confident that I accomplished what @nmaludy has asked of me.

nmaludy commented 3 years ago

@lattisimo Your changes look good, we're just in a change freeze right now due to a pending 3.3.0 release. I'm going to target this for the 3.4.0 milestone, does that sound good?

lattisimo commented 3 years ago

Sounds good. Thanks.

CLAassistant commented 2 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: lattisimo
:x: Shawn Robinson

Shawn Robinson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}