Fix `packs.get` action - Githubissues

StackStorm / st2

StackStorm (aka "IFTTT for Ops") is event-driven automation for auto-remediation, incident responses, troubleshooting, deployments, and more for DevOps and SREs. Includes rules engine, workflow, 160 integration packs with 6000+ actions (see https://exchange.stackstorm.org) and ChatOps. Installer at https://docs.stackstorm.com/install/index.html

https://stackstorm.com/

Apache License 2.0

6.09k stars 746 forks source link

Fix `packs.get` action #6226

Closed jpavlav closed 2 months ago

jpavlav commented 4 months ago

Addresses #6225. This should allow users to specify a branch when using the packs.get command. This addresses the assumption in the code that the primary branch of a git repository corresponding to an action is master.

Add branch parameter to get.yaml. Default to master to maintain current functionality/expectations.
Update run in pack_mgmt.get_install.py. Now accepts branch param and uses an fstring to represent the in git rev list.

jpavlav commented 4 months ago

I can add tests here, if that is required. There are, however, not any existing tests for this action, so I thought it might not be. Fundamentally, the change here is very small and the action is very simple. Whomever reviews this, let me know if new tests are required.