Closed cognifloyd closed 2 months ago
The Test / Test (pants runs: pytest)
CI failures are not related to this PR. To validate that, I re-ran the success CI in #6244, and now it fails there too. So, it seem to be some GHA issue.
Luckily, the pants workflows are not required to merge PRs (in branch protection rules), so please ignore the failure.
Thanks for going through this. The noop driver random failures were a pain to deal with.
The graceful_shutdown tests have been very flaky using the
NoOpDriver
. Switching fromNoOpDriver
toRedisDriver
will hopefully make our CI more stable.This was discussed in a TSC meeting and implemented by @FileMagic (#6223) and @guzzijones (#6236). I cherry-picked the redis-related parts of their excellent work. After stumbling through the cherry-picks (I missed a few things, and had to rebase/cherry-pick a few times), I refactored a few things:
redis
container defined inservices
, dropping the tasks that managed it manually.ST2TESTS_REDIS_*
as the format for new env vars instead ofST2_OVERRIDE_COORDINATOR_REDIS_*
.:clap: Thank you @FileMagic and @guzzijones for getting this figured out! I have high hopes for more stable CI thanks to your excellent work! :tada: