StackStorm / st2

StackStorm (aka "IFTTT for Ops") is event-driven automation for auto-remediation, incident responses, troubleshooting, deployments, and more for DevOps and SREs. Includes rules engine, workflow, 160 integration packs with 6000+ actions (see https://exchange.stackstorm.org) and ChatOps. Installer at https://docs.stackstorm.com/install/index.html
https://stackstorm.com/
Apache License 2.0
6.09k stars 746 forks source link

Make unit tests use redis #6245

Closed cognifloyd closed 2 months ago

cognifloyd commented 2 months ago

The graceful_shutdown tests have been very flaky using the NoOpDriver. Switching from NoOpDriver to RedisDriver will hopefully make our CI more stable.

This was discussed in a TSC meeting and implemented by @FileMagic (#6223) and @guzzijones (#6236). I cherry-picked the redis-related parts of their excellent work. After stumbling through the cherry-picks (I missed a few things, and had to rebase/cherry-pick a few times), I refactored a few things:

:clap: Thank you @FileMagic and @guzzijones for getting this figured out! I have high hopes for more stable CI thanks to your excellent work! :tada:

cognifloyd commented 2 months ago

The Test / Test (pants runs: pytest) CI failures are not related to this PR. To validate that, I re-ran the success CI in #6244, and now it fails there too. So, it seem to be some GHA issue.

Luckily, the pants workflows are not required to merge PRs (in branch protection rules), so please ignore the failure.

guzzijones commented 2 months ago

Thanks for going through this. The noop driver random failures were a pain to deal with.