search

StackStorm / st2

StackStorm (aka "IFTTT for Ops") is event-driven automation for auto-remediation, incident responses, troubleshooting, deployments, and more for DevOps and SREs. Includes rules engine, workflow, 160 integration packs with 6000+ actions (see https://exchange.stackstorm.org) and ChatOps. Installer at https://docs.stackstorm.com/install/index.html
https://stackstorm.com/
Apache License 2.0
6.09k stars 746 forks source link

Bump dnspython to 2.6.1 to fix pack CI failure on py3.10/py3.11 #6265

Closed nzlosh closed 4 weeks ago

nzlosh commented 1 month ago

Update dnspython to v2.6.1 to fix pack CI failing for py3.10 / py3.11 with AttributeError: module 'collections' has no attribute 'MutableMapping'.

cognifloyd commented 1 month ago

dnspython is a transitive dep -- we don't use it directly. It looks like it is a dependency of:

What if we just removed dnspython from our requirements files and let pip pick the version?

Or, what if we just removed the constraint from lockfiles/st2-constraints.txt and update fixed-requirements.txt with whatever version got locked (this is probably similar to what you've done here)?

cognifloyd commented 1 month ago

To clarify: the original reason for pinning dnspython in #4997 (an incompatibility between dnspython and pymongo) no longer applies. We've upgraded pymongo several times since then, and it clearly supports newer versions, so the constraint is not needed any more.

nzlosh commented 1 month ago

Dropped pinning for dnspython as suggested.