search

StackStorm / st2chatops

Packaging environment for building StackStorm chatops native packages
Apache License 2.0
32 stars 42 forks source link

Use 'ST2_API_URL' ENV instead of 'ST2_API' for consistency #119

Closed arm4b closed 5 years ago

arm4b commented 5 years ago

This is spot during the K8s work https://github.com/StackStorm/st2-dockerfiles/pull/19

Complementing https://github.com/StackStorm/hubot-stackstorm/pull/163

For consistency with other ENV variables (see https://docs.stackstorm.com/reference/cli.html#configuration), rename ST2_API -> ST2_API_URL.

Per https://github.com/StackStorm/hubot-stackstorm/pull/163 we still support old ST2_API for backwards compatibility. If there is some old ST2_API env var defined, it will take precedence and hubot will show a deprecation warning in logs. It means if user keeps old st2chatops.env, - it still would work after deb/rpm package upgrade.