search

StackStorm / st2chatops

Packaging environment for building StackStorm chatops native packages
Apache License 2.0
32 stars 41 forks source link

add set -euo pipefail to docker-entrypoint.sh files #144

Closed punkrokk closed 4 years ago

punkrokk commented 4 years ago

Fixes: #143 as requested by @armab Fixes #48

added the following to docker-entrypoint.sh files in all packaging and testing containers:

set -eu
set -o pipefail
arm4b commented 4 years ago

According to build failures looks like this uncovered a can of worms, which is good in general and what it should do. Check the build logs for possible fixes. Also good call and intuition to work on it in a separated PR :+1:

arm4b commented 4 years ago

Looks like this abandoned PR is part of the v3.3.0 release. @punkrokk any update on finishing it?

punkrokk commented 4 years ago

@blag and I agree this is likely a can of worms and it should be moved to 3.4.

On Thu, Sep 10, 2020 at 9:17 AM Eugen C. notifications@github.com wrote:

Looks like this abandoned PR is part of the v3.3.0 release. @punkrokk https://github.com/punkrokk any update on finishing it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/StackStorm/st2chatops/pull/144#issuecomment-690281472, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIMM6SGR3KTGODXYWYXK6TSFDGYFANCNFSM4KLSULXA .

-- JP

arm4b commented 4 years ago

A can of worms is when any failure in st2chatops deb/rpm build results in a successful status. That's a curent issue. This PR fixes this incorrect behavior which is one of the chatops maintenance tasks.

I just pushed a tiny change to rectify issues left in this PR so we'll able to merge it.