search

StackStorm / st2chatops

Packaging environment for building StackStorm chatops native packages
Apache License 2.0
32 stars 41 forks source link

Update botframework, spark, and stackstorm hubot plugins to latest #147

Closed blag closed 4 years ago

blag commented 4 years ago

Update dependencies to their latest versions.

This PR includes changes from #141, to fix a few issues when integrating with Microsoft Teams. Thank you to LizhangX.

This PR also switches the hubot-spark adapter to using a git commit, since the version of hubot-spark available on NPM is not the most up-to-date, and the Spark adapter in hubot-stackstorm depends on the most recent (as of this writing) changes in that hubot-spark Hubot plugin.

Thanks to @VivekSyngh, the hubot-stackstorm plugin has been updated to work against Webex (Cisco Spark was renamed to Webex Teams), so that dependency is also updated and pulled normally from NPM.

This slims down the npm-shrinkwrap.json file a bit, (I think) because we are no longer including devDependencies for hubot-stackstorm.

Not sure why the tests are failing. Will investigate and fix them.

arm4b commented 4 years ago

The problem is that shrinkwrap change here includes all possible dependency updates with +2,207 −2,626 diff.

Try to follow this guide https://github.com/StackStorm/st2chatops/issues/104 to regenerate only needed dependencies in shrinkwrap.

blag commented 4 years ago

That guide is good, and I'm redoing the PR to follow that, but using npm update wouldn't change the hubot-botframework or hubot-spark dependencies the way I need to here, since I'm not trying to simply update those components to their most recently released versions. I'm trying to install those components from specific git commits, not released versions. For those I have to use npm install --save <...>.

I'm currently redoing this PR to break up the changes to package.json and npm-shrinkwrap.json into the individual npm operations, to give better clarity into why the diff for this PR is so large. Unfortunately there was a lot of churn in the Cisco Spark to Webex rename, so the diff for that change is still rather large. As far as I know, I can't do anything about that.

blag commented 4 years ago

The npm update command didn't update hubot-stackstorm even though version 0.10.2 is released on NPM, so I used npm install --save hubot-stackstorm@^0.10.2 to update that one.

And a final docker-compose run xenial npm-shrinkwrap didn't change any files.