search

StackStorm / st2chatops

Packaging environment for building StackStorm chatops native packages
Apache License 2.0
32 stars 42 forks source link

Upgrade node 20 #186

Open rebrowning opened 11 months ago

rebrowning commented 11 months ago

pin coffeescript which will allow builds with node 20 to succeed. No other libraries needed to be updated (excluding and assuming no issues with hubot-botframework if someone has access to it)

locally I have to remove hubot-botframework, hopefully someone in the community has access to that repo, but the current most recent (6 years+) npm version does not work, and the repo has some restrictions that prevents me from pulling anything from the repo. I can't even clone it to test a local file module.

I also upgraded the node version in focal and rocky, using nvm to do the install. The two older versions do not have a compiler that can install node 20, I'm not sure what we want to do about that but a few attempts at doing it cleanly were unsuccessful, I'm not sure if supporting them warrants doing a sketchy secondary install of a compiler to try and make it work.

open to any feedback of what else needs to be updated to try and move this forwards.

amanda11 commented 8 months ago

@rebrowning I've managed to fix some of the build errors in my PR #188, so you should find that once I have that merged if you merge from master it should fix the issues you were seeing on build. That PR also removes bionic and el7 which we don't need for the next release. FYI there is also a Wiki about the various places that come into play when upgrading NodeJS version: https://github.com/StackStorm/st2/wiki/How-To:-Upgrade-Node.js-version

amanda11 commented 8 months ago

@rebrowning Hi, I'm not sure if you are able to help. But we're trying to get st2chatops to run with node20 now that we have got rid of the older OS vefrsions, and fixed some issues that were failing st2chatops build. I've tried to take some of your changes into #189 - but am having problems. If you have time perhaps we can get this PR back to how you had it so that it built with node 20? It would be great if we could, as I think you got closer to a fix then I am having. Any pointers ,help or guidance would be appreciated.

rebrowning commented 8 months ago

@amanda11 Not sure what the failure is, but if you're getting an npm login error when I was running this locally I had to remove the hubot-botframework as the current pinned version to a git repo does not work, and there are no more recent versions available. This specifically was effects teams support. I was hoping it was just a credential issue on my side and that the st2 pipeline would pull + build it.