Closed Kami closed 5 years ago
@nmaludy Just a heads up.
I will also go ahead and publish v0.5.1 to PyPi once this is merged.
To confirm this change is also working on CI, I pushed a "dummy" issue - https://circleci.com/gh/StackStorm/st2sdk/326?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link, https://circleci.com/gh/StackStorm/st2sdk/325?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link.
:+1:
This pull request improves existing sdist tests so they also uncover issues which are related to
setup.py
depending on a 3rd party library such as the one inadvertently introduced in #27.Before, those checks would pass since
six
dependency was being installed in the virtual environment where that check runs.